lkml.org 
[lkml]   [2008]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] tipc: Use the appropriate swab helper rather than an internal helper
    From
    Date
    On Tue, 2008-08-12 at 21:20 -0700, Andrew Morton wrote:
    > On Tue, 12 Aug 2008 21:05:47 -0700 Harvey Harrison <harvey.harrison@gmail.com> wrote:
    >
    > > ___generally means I am an internal implementation detail, don't use
    > > me.
    > >
    > > Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
    > > ---
    > > Sorry for breaking the build Andrew, my testing has been with all the __constant
    > > versions in-tree removed.
    > >
    > > net/tipc/subscr.c | 2 +-
    > > 1 files changed, 1 insertions(+), 1 deletions(-)
    > >
    > > diff --git a/net/tipc/subscr.c b/net/tipc/subscr.c
    > > index 0326d30..f5da05d 100644
    > > --- a/net/tipc/subscr.c
    > > +++ b/net/tipc/subscr.c
    > > @@ -85,7 +85,7 @@ static struct top_srv topsrv = { 0 };
    > >
    > > static u32 htohl(u32 in, int swap)
    > > {
    > > - return swap ? (u32)___constant_swab32(in) : in;
    > > + return swap ? (u32)swab32(in) : in;
    > > }
    >
    > yes, that's what I did too, only I dropped the
    > seems-to-me-to-be-unneeded (u32) cast.

    I made the mistake of folding this bit into the series that removes all
    users of the __constant_ helpers as I forgot it was a build breaker.
    That's why I wasn't seeing it here.

    Harvey



    \
     
     \ /
      Last update: 2008-08-13 06:27    [W:0.020 / U:32.428 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site