| Subject | Re: [PATCH 16 of 55] xen64: add extra pv_mmu_ops | From | Mark McLoughlin <> | Date | Wed, 09 Jul 2008 08:55:10 +0100 |
| |
Hey Jeremy,
On Tue, 2008-07-08 at 15:06 -0700, Jeremy Fitzhardinge wrote: > We need extra pv_mmu_ops for 64-bit, to deal with the extra level of > pagetable. > > Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> > --- > arch/x86/xen/enlighten.c | 33 +++++++++++++++++++++++++++- > arch/x86/xen/mmu.c | 51 +++++++++++++++++++++++++++++++++++++++++++- > arch/x86/xen/mmu.h | 15 +++++++++++- > include/asm-x86/xen/page.h | 4 +++ > 4 files changed, 99 insertions(+), 4 deletions(-) ... > diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c > --- a/arch/x86/xen/mmu.c > +++ b/arch/x86/xen/mmu.c > @@ -438,14 +438,19 @@ > > void xen_set_pte(pte_t *ptep, pte_t pte) > { > +#ifdef CONFIG_X86_PAE > ptep->pte_high = pte.pte_high; > smp_wmb(); > ptep->pte_low = pte.pte_low; > +#else > + *ptep = pte; > +#endif > }
You've dropped non-PAE support already, right? Any reason to use the X86_PAE macro instead of X86_32?
Cheers, Mark.
|