Messages in this thread | | | Date | Thu, 10 Jul 2008 19:29:06 -0700 | From | Mike Travis <> | Subject | Re: [patch 19/26] x64, x2apic/intr-remap: introcude self IPI to genapic routines |
| |
Eric W. Biederman wrote: >> Index: tree-x86/include/asm-x86/hw_irq.h >> =================================================================== >> --- tree-x86.orig/include/asm-x86/hw_irq.h 2008-07-10 09:51:45.000000000 -0700 >> +++ tree-x86/include/asm-x86/hw_irq.h 2008-07-10 09:52:24.000000000 -0700 >> @@ -73,7 +73,9 @@ >> #endif >> >> /* IPI functions */ >> +#ifdef CONFIG_X86_32 >> extern void send_IPI_self(int vector); >> +#endif >> extern void send_IPI(int dest, int vector); > > Cute undoing unification. > > Eric
On a similar subject I would really like to change the send_IPI_mask to pass a pointer to the cpumask_t arg:
void (*send_IPI_mask)(cpumask_t mask, int vector);
This bloats the stack by 512 bytes and seemingly is called by some fairly nested routines. Any opinions?
Thanks, Mike
| |