Messages in this thread Patch in this message | | | Subject | [PATCH] net/inet_lro: remove setting skb->ip_summed when not LRO-able | From | Eli Cohen <> | Date | Tue, 24 Jun 2008 17:39:46 +0300 |
| |
>From 59c28d377ddfb7c13e2e1ecbf184211704d0e61d Mon Sep 17 00:00:00 2001 From: Eli Cohen <eli@mellanox.co.il> Date: Tue, 24 Jun 2008 17:17:14 +0300 Subject: [PATCH] net/inet_lro: remove setting skb->ip_summed when not LRO-able
When an SKB cannot be chained to a session, the current code attempts to "restore" its ip_summed field from lro_mgr->ip_summed. However, lro_mgr->ip_summed does not hold the original value; in fact, we'd better not touch skb->ip_summed since it is not modified by the code in the path leading to a failure to chain it.
Issue raised by Or Gerlitz <ogerlitz@voltaire.com>
Signed-off-by: Eli Cohen <eli@mellanox.co.il> --- net/ipv4/inet_lro.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/inet_lro.c b/net/ipv4/inet_lro.c index 4a4d49f..cfd034a 100644 --- a/net/ipv4/inet_lro.c +++ b/net/ipv4/inet_lro.c @@ -383,8 +383,7 @@ static int __lro_proc_skb(struct net_lro_mgr *lro_mgr, struct sk_buff *skb, out2: /* send aggregated SKBs to stack */ lro_flush(lro_mgr, lro_desc); -out: /* Original SKB has to be posted to stack */ - skb->ip_summed = lro_mgr->ip_summed; +out: return 1; } -- 1.5.6
| |