Messages in this thread | | | Date | Mon, 02 Jun 2008 11:52:30 +0100 | From | Jeremy Fitzhardinge <> | Subject | Re: [Xen-devel] [PATCH 10 of 12] xen: implement save/restore |
| |
Isaku Yamahata wrote: > On Mon, Jun 02, 2008 at 11:03:36AM +0100, Jeremy Fitzhardinge wrote: > >> Isaku Yamahata wrote: >> >>> What is the purpose of load_cr3() here? >>> I'd like to make this load_cr3() more arch generic for ia64 support. >>> (or eliminate it if possible) >>> >>> >> I think it's an unnecessary left-over from when I was trying to get that >> stuff to work. I can't think of a good reason not to just remove it if >> it causes you problems. >> > > Here is the patch. I did only compile test. > > > >> BTW, I tried to split the suspend/resume stuff into common and things >> which were definitely x86-specific with you in mind. How close did I get? >> > > Almost complete. Your effort made my task easier. > I haven't yet succeeded to save/restore, though. > > Is CONFIG_PM_SLEEP necessary? > Yes.
It's necessary because the Xen save/restore code calls into various core functions to handle things like resuming timekeeping; that code is compiled controlled by CONFIG_PM_SLEEP.
> Since ia64 doesn't define ARCH_HIBERNATION_POSSIBLE nor > ARCH_SUSPEND_POSSIBLE. > Although I can define them in ia64/xen/Kconfig, I'd like to leave > them untouched if possible. >
Hm, not sure how can address that then.
I'll confirm test that the load_cr3() is unnecessary later today.
J
| |