lkml.org 
[lkml]   [2008]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/6] res_counter: handle limit change
    KAMEZAWA Hiroyuki wrote:
    > Add a support to shrink_usage_at_limit_change feature to res_counter.
    > memcg will use this to drop pages.
    >
    > Change log: xxx -> v4 (new file.)
    > - cut out the limit-change part from hierarchy patch set.
    > - add "retry_count" arguments to shrink_usage(). This allows that we don't
    > have to set the default retry loop count.
    > - res_counter_check_under_val() is added to support subsystem.
    > - res_counter_init() is res_counter_init_ops(cnt, NULL)
    >
    > Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
    >

    Does shrink_usage() really belong to res_counters? Could a task limiter, a
    CPU/IO bandwidth controller use this callback? Resource Counters were designed
    to be generic and work across controllers. Isn't the memory controller a better
    place for such ops.

    --
    Warm Regards,
    Balbir Singh
    Linux Technology Center
    IBM, ISTL


    \
     
     \ /
      Last update: 2008-06-16 11:01    [W:0.021 / U:91.736 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site