lkml.org 
[lkml]   [2008]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
Subject[RFC][PATCH] kmemcheck: divide and conquer
From
Hi,

I've split the main x86/mm/kmemcheck.c file and made a subdirectory of many
files instead.

I have included the diffstat below, but I think the patch itself is too big
for the mailing list. It can instead be viewed at:

http://www.kernel.org/pub/linux/kernel/people/vegard/patches/0001-kmemcheck-divide-and-conquer.patch

The RFC part: Is this a good thing to do? I personally hate the 4000-line
files that are so commonly found in the kernel, and therefore prefer this
split-up. On the other hand, C lacks namespaces, which sometimes leads to
some really long and ugly names just to prevent clashes in the future. But
it's your call, I'll just do whatever it takes to get in... ;-)


Vegard


Author: Vegard Nossum <vegard.nossum@gmail.com>
Date: Wed Jun 11 12:37:13 2008 +0200

kmemcheck: divide and conquer

This patch splits the kmemcheck.c into a subdirectory of many files. This
makes it easier to get around the different functions because they're now
grouped together by file.

Signed-off-by: Vegard Nossum <vegard.nossum@gmail.com>

arch/x86/mm/Makefile | 2 +-
arch/x86/mm/kmemcheck.c | 1100 -------------------------------------
arch/x86/mm/kmemcheck/Makefile | 3 +
arch/x86/mm/kmemcheck/error.c | 215 ++++++++
arch/x86/mm/kmemcheck/error.h | 15 +
arch/x86/mm/kmemcheck/kmemcheck.c | 477 ++++++++++++++++
arch/x86/mm/kmemcheck/opcode.c | 70 +++
arch/x86/mm/kmemcheck/opcode.h | 9 +
arch/x86/mm/kmemcheck/pte.c | 22 +
arch/x86/mm/kmemcheck/pte.h | 10 +
arch/x86/mm/kmemcheck/shadow.c | 174 ++++++
arch/x86/mm/kmemcheck/shadow.h | 16 +
arch/x86/mm/kmemcheck/smp.c | 79 +++
arch/x86/mm/kmemcheck/smp.h | 23 +
arch/x86/mm/kmemcheck/string.c | 91 +++
include/linux/kmemcheck.h | 3 +
16 files changed, 1208 insertions(+), 1101 deletions(-)


\
 
 \ /
  Last update: 2008-06-13 16:05    [W:0.211 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site