Messages in this thread | | | Date | Wed, 28 May 2008 01:06:55 +0900 | From | "KOSAKI Motohiro" <> | Subject | Re: [PATCH 2/3] slub: record page flag overlays explicitly |
| |
>> > - if (SlabDebug(page)) >> > - printk(KERN_ERR "SLUB %s: SlabDebug set on " >> > + if (PageSlubDebug(page)) >> > + printk(KERN_ERR "SLUB %s: SlubDebug set on " >> > "slab 0x%p\n", s->name, page); >> > } >> > } >> >> Why if(SLABDEBUG) check is unnecessary? > > They were unconditional before as well. SlabDebug would always return > 0 before the patch. The point being, to my reading, that if you asked > for debug on the slab and debug was not compiled in you would still get > told that it was not set; which it cannot without the support.
Thank you explain!
Tested-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
| |