lkml.org 
[lkml]   [2008]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] slub: record page flag overlays explicitly
>> > -           if (SlabDebug(page))
>> > - printk(KERN_ERR "SLUB %s: SlabDebug set on "
>> > + if (PageSlubDebug(page))
>> > + printk(KERN_ERR "SLUB %s: SlubDebug set on "
>> > "slab 0x%p\n", s->name, page);
>> > }
>> > }
>>
>> Why if(SLABDEBUG) check is unnecessary?
>
> They were unconditional before as well. SlabDebug would always return
> 0 before the patch. The point being, to my reading, that if you asked
> for debug on the slab and debug was not compiled in you would still get
> told that it was not set; which it cannot without the support.

Thank you explain!

Tested-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>


\
 
 \ /
  Last update: 2008-05-27 18:09    [W:6.692 / U:0.476 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site