lkml.org 
[lkml]   [2008]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/3] slub: record page flag overlays explicitly
    Hi

    This patch works well on my box.
    but I have one question.

    > if (s->flags & DEBUG_DEFAULT_FLAGS) {
    > - if (!SlabDebug(page))
    > - printk(KERN_ERR "SLUB %s: SlabDebug not set "
    > + if (!PageSlubDebug(page))
    > + printk(KERN_ERR "SLUB %s: SlubDebug not set "
    > "on slab 0x%p\n", s->name, page);
    > } else {
    > - if (SlabDebug(page))
    > - printk(KERN_ERR "SLUB %s: SlabDebug set on "
    > + if (PageSlubDebug(page))
    > + printk(KERN_ERR "SLUB %s: SlubDebug set on "
    > "slab 0x%p\n", s->name, page);
    > }
    > }

    Why if(SLABDEBUG) check is unnecessary?





    \
     
     \ /
      Last update: 2008-05-26 06:55    [W:0.022 / U:0.880 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site