lkml.org 
[lkml]   [2008]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] slub: record page flag overlays explicitly
Hi

This patch works well on my box.
but I have one question.

> if (s->flags & DEBUG_DEFAULT_FLAGS) {
> - if (!SlabDebug(page))
> - printk(KERN_ERR "SLUB %s: SlabDebug not set "
> + if (!PageSlubDebug(page))
> + printk(KERN_ERR "SLUB %s: SlubDebug not set "
> "on slab 0x%p\n", s->name, page);
> } else {
> - if (SlabDebug(page))
> - printk(KERN_ERR "SLUB %s: SlabDebug set on "
> + if (PageSlubDebug(page))
> + printk(KERN_ERR "SLUB %s: SlubDebug set on "
> "slab 0x%p\n", s->name, page);
> }
> }

Why if(SLABDEBUG) check is unnecessary?




\
 
 \ /
  Last update: 2008-05-26 06:55    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site