Messages in this thread Patch in this message | | | Subject | 2.6.26-rc2-mm1 and Linus -git: LEDS_TRIGGER_DEFAULT_ON odd default | From | Valdis.Kletnieks@vt ... | Date | Sat, 17 May 2008 06:28:13 -0400 |
| |
On Wed, 14 May 2008 01:01:29 PDT, Andrew Morton said: > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.26-rc2/2.6.26-rc2-mm1/
Seen in a 'make silentoldconfig':
--- LED Default ON Trigger (LEDS_TRIGGER_DEFAULT_ON) [N/m/y/?] (NEW) ?
This allows LEDs to be initialised in the ON state. If unsure, say Y. ---
The default is N, but if unsure, say Y. Some digging shows that it's because there's a "depends on LEDS_TRIGGERS" that I had set to N. I wonder if the various 'config LEDS_TRIGGER_FOO' in drivers/leds/Kconfig should all be wrapped in one 'if LEDS_TRIGGERS'? Kind of like this totally untested patch:
If I'm actually right here, here's a:
Signed-Off-By: Valdis Kletnieks <valdis.kletnieks@vt.edu>
--- linux-2.6.26-rc2-mm1/drivers/leds/Kconfig.before 2008-05-17 06:22:03.000000000 -0400 +++ linux-2.6.26-rc2-mm1/drivers/leds/Kconfig 2008-05-17 06:22:55.000000000 -0400 @@ -164,9 +164,9 @@ config LEDS_TRIGGERS These triggers allow kernel events to drive the LEDs and can be configured via sysfs. If unsure, say Y. +if LEDS_TRIGGERS config LEDS_TRIGGER_TIMER tristate "LED Timer Trigger" - depends on LEDS_TRIGGERS help This allows LEDs to be controlled by a programmable timer via sysfs. Some LED hardware can be programmed to start @@ -177,14 +177,13 @@ config LEDS_TRIGGER_TIMER config LEDS_TRIGGER_IDE_DISK bool "LED IDE Disk Trigger" - depends on LEDS_TRIGGERS && BLK_DEV_IDEDISK + depends on BLK_DEV_IDEDISK help This allows LEDs to be controlled by IDE disk activity. If unsure, say Y. config LEDS_TRIGGER_HEARTBEAT tristate "LED Heartbeat Trigger" - depends on LEDS_TRIGGERS help This allows LEDs to be controlled by a CPU load average. The flash frequency is a hyperbolic function of the 1-minute @@ -193,9 +192,9 @@ config LEDS_TRIGGER_HEARTBEAT config LEDS_TRIGGER_DEFAULT_ON tristate "LED Default ON Trigger" - depends on LEDS_TRIGGERS help This allows LEDs to be initialised in the ON state. If unsure, say Y. +endif # LEDS_TRIGGERS endif # NEW_LEDS
[unhandled content-type:application/pgp-signature] | |