Messages in this thread | | | Date | Fri, 16 May 2008 10:46:07 +0200 | From | Clemens Ladisch <> | Subject | Re: [PATCH] x86: Get irq for hpet timer |
| |
Kevin Hao wrote: > HPET timer's IRQ is 0 by default, so we have to select which irq > will be used for these timers. We wait to set the timer's irq until > we really turn on interrupt in order to reduce the chance of > conflicting with some legacy device. > > + for (irq = find_first_bit(&cap, HPET_MAX_IRQ); irq < HPET_MAX_IRQ; > + irq = find_next_bit(&cap, HPET_MAX_IRQ, 1 + irq)) { > + if (request_irq(irq, hpet_interrupt, irq_flags, > + devp->hd_name, (void *)devp)) { > + printk(KERN_WARNING "hpet: IRQ %d is not free\n", irq); > + continue;
This warning message will be output for every interrupt that is in use by another device. I think it would be better to postpone complaining until after the loop, if no interrupt has been found at all.
Regards, Clemens
| |