Messages in this thread | | | From | Balaji Rao <> | Subject | Re: [PATCH] x86: Get irq for hpet timer | Date | Fri, 16 May 2008 14:00:32 +0530 |
| |
On Friday 16 May 2008 01:33:25 pm Kevin Hao wrote: > On Fri, 2008-05-16 at 13:23 +0530, Balaji Rao R wrote: > > On Fri, May 16, 2008 at 11:35 AM, Kevin Hao <kexin.hao@windriver.com> wrote: > > > Hi, > > > > > > x86: get irq for hpet timer > > > > > > HPET timer's IRQ is 0 by default, so we have to select which irq > > > will be used for these timers. We wait to set the timer's irq until > > > we really turn on interrupt in order to reduce the chance of > > > conflicting with some legacy device. > > > > Yes, this is alright. But i've seen some machines where we have a > > valid IRQ in 'devp->hd_hdwirq' which you should not ignore. So, first > > check if it is zero and only then do a hpet_timer_get_irq. > > Yes, I have checked that case in hpet_timer_get_irq function. See the > following code: > > + irq = devp->hd_hdwirq; > > > + if (irq) { > + if (request_irq(irq, hpet_interrupt, irq_flags, > + devp->hd_name, (void *)devp)) { > + printk(KERN_ERR "hpet: IRQ %d is not free\n", > irq); > + irq = 0; > + } > + return irq; > + } > > Is that right? > Yes. You are right. Sorry for not going through the patch fully before making noise.
-- Warm Regards,
Balaji Rao Dept. of Mechanical Engineering NITK
| |