lkml.org 
[lkml]   [2008]   [May]   [13]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateTue, 13 May 2008 14:44:54 +0200
FromIngo Molnar <>
SubjectRe: [PATCH 2/3] x86: janitor work in bugs.c
* Miklos Vajna <vmiklos@frugalware.org> wrote:

> -		printk(KERN_EMERG "No coprocessor found and no math emulation present.\n");
> +		printk(KERN_EMERG "No coprocessor found and no math "
> +			"emulation present.\n");

generally we do not break up strings mid-stream - that makes grepping 
harder. _At most_ we do something like:

		printk(KERN_EMERG
		       "No coprocessor found and no math emulation present.\n");

> -/* trap_init() enabled FXSR and company _before_ testing for FP problems here. */
> +/* trap_init() enabled FXSR and company _before_ testing for FP problems
> + * here. */

that's not the proper multi-line comment style, this would be:

  /*
   * trap_init() enabled FXSR and company _before_ testing for
   * FP problems here.
   */
same for other places in this patch and for your next patch.

	Ingo


\
 
 \ /
  Last update: 2008-05-13 14:47    [from the cache]
©2003-2008