lkml.org 
[lkml]   [2008]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 2/3] x86: janitor work in bugs.c
    From
    Date
    Miklos Vajna <vmiklos@frugalware.org> writes:
    > if (!boot_cpu_data.hard_math) {
    > #ifndef CONFIG_MATH_EMULATION
    > - printk(KERN_EMERG "No coprocessor found and no math emulation present.\n");
    > + printk(KERN_EMERG "No coprocessor found and no math "
    > + "emulation present.\n");

    This means if someone gets this message and wants to grep for it they won't
    find it. Bad bad bad.

    We had a discussion recently that wrapping printk format strings
    is a bad idea. Don't do it please.

    -Andi


    \
     
     \ /
      Last update: 2008-05-13 23:13    [W:0.020 / U:1.392 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site