lkml.org 
[lkml]   [2008]   [May]   [13]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/3] x86: janitor work in bugs.c
FromAndi Kleen <>
DateTue, 13 May 2008 23:09:24 +0200
Miklos Vajna <vmiklos@frugalware.org> writes:
>  	if (!boot_cpu_data.hard_math) {
>  #ifndef CONFIG_MATH_EMULATION
> -		printk(KERN_EMERG "No coprocessor found and no math emulation present.\n");
> +		printk(KERN_EMERG "No coprocessor found and no math "
> +			"emulation present.\n");

This means if someone gets this message and wants to grep for it they won't
find it. Bad bad bad.

We had a discussion recently that wrapping printk format strings
is a bad idea. Don't do it please.

-Andi


\
 
 \ /
  Last update: 2008-05-13 23:13    [from the cache]
©2003-2008