lkml.org 
[lkml]   [2008]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [regression] e1000e broke e1000

* Kok, Auke <auke-jan.h.kok@intel.com> wrote:

> > it is an obvious regression that could and should be solved in the
> > Kconfig space: do not allow E1000=y && E1000E=m.
>
> this is really not the solution imho, having e1000 builtin and e1000e
> as a module is a perfectly viable choice. They are two separate
> drivers that are completely independent.

you try to argue against a strong and established concept that Linux
always had from day one on: DRIVER_X=y means the user prefers that
driver so strongly that he has selected it built-in. Such drivers are
special in every sense: they run first before any of the module init,
they cannot be disabled, etc. etc.

The only case where that should be overriden as the primary driver for
that piece of hardware if _another_ driver is built-in _too_.

... which is exactly the E1000=y && E1000E=m regression that bit me and
the simple solution of forcing E1000E to follow the mode of the E1000
driver solves it.

The most common distro setup is E1000=m and E1000E=m. The most common
embedded setup is _one_ of the two drivers as =y. So i'm not sure why
you are arguing about all this. Please just fix this bug, simple as
that.

Ingo


\
 
 \ /
  Last update: 2008-04-09 21:15    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site