[lkml]   [2008]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] netfilter: replace horrible hack with ksize()
Pekka J Enberg wrote:
> On Thu, 6 Mar 2008, Patrick McHardy wrote:
>> It decides to reallocate when the remaining space isn't enough
>> to hold the new data. NF_CT_EXT_MIN_SIZE is used to make sure it
>> doesn't allocate anything smaller than the minimum slab size and
>> hopefully avoid reallocations in the future. Unless I'm
>> misunderstanding what ksize() does, the easiest way to get
>> rid of this would be to replace NF_CT_EXT_MIN_SIZE by ksize(0).
> I think you are misunderstanding ksize() (see mm/slub.c::ksize() for
> example).

The ksize() description in mm/slab.c matches exactly what netfilter
wants to do:

* kmalloc may internally round up allocations and return more memory
* than requested. ksize() can be used to determine the actual amount
* memory allocated. The caller may use this additional memory, even though
* a smaller amount of memory was initially specified with the kmalloc

> Furthermore, I think your current reallocation code is broken
> too as explained in a previous mail and my patch fixes that to behave as
> krealloc() does.

I don't think there is anything broken with that code.

The initial allocation size is calculated as max(size, min slab size)
and is stored as ext->alloc_size. When adding the first extension,
it allocates ext->alloc_size of memory and stores both the real amount
of space used (ext->len) and the actual size (ext->real_len).
When adding further extensions, it calculates the new total amount of
space needed (newlen). If that is larger than the real amount of
memory allocated (real_len), it reallocates.

What am I missing here?

 \ /
  Last update: 2008-03-06 15:55    [W:0.071 / U:8.500 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site