Messages in this thread | | | Date | Thu, 6 Mar 2008 16:41:58 +0200 (EET) | From | Pekka J Enberg <> | Subject | Re: [PATCH] netfilter: replace horrible hack with ksize() |
| |
On Thu, 6 Mar 2008, Patrick McHardy wrote: > It decides to reallocate when the remaining space isn't enough > to hold the new data. NF_CT_EXT_MIN_SIZE is used to make sure it > doesn't allocate anything smaller than the minimum slab size and > hopefully avoid reallocations in the future. Unless I'm > misunderstanding what ksize() does, the easiest way to get > rid of this would be to replace NF_CT_EXT_MIN_SIZE by ksize(0).
I think you are misunderstanding ksize() (see mm/slub.c::ksize() for example). Furthermore, I think your current reallocation code is broken too as explained in a previous mail and my patch fixes that to behave as krealloc() does.
Pekka
| |