Messages in this thread Patch in this message | | | Date | Tue, 25 Mar 2008 03:46:03 +0100 | From | Rene Herman <> | Subject | Re: [alsa-devel] [regression] 2.6.25-rc4 snd-es18xx broken on Alpha |
| |
On 25-03-08 01:29, Rene Herman wrote:
> On 25-03-08 00:56, Michael Cree wrote:
> >> At this stage I've run out of time to test the M-Audio Rev in the >> XP1000 and see if the MMAP disable patch help there. > > Given that it fixes es18xx and cmipci on the PWS600au and that those > worked without trouble on the XP1000, you'd _expect_ not, but the OOPs > you posted before seemed to indicate that it stands a fair chance afer all.
Oh, by the way, note that it only disabled mmap for CONFIG_ALPHA_MIATA due to your report of es18xx working fine on the XP1000, so you'll have to change that to CONFIG_ALPHA_DP264 for the XP1000 to actually test it there:
(or just delete SNDRV_PCM_INFO_MMAP from the info structures in the driver as Takashi earlier instructed)
Rene. diff --git a/include/sound/asound.h b/include/sound/asound.h index 3eaf155..e3b9c2d 100644 --- a/include/sound/asound.h +++ b/include/sound/asound.h @@ -241,8 +241,14 @@ typedef int __bitwise snd_pcm_subformat_t; #define SNDRV_PCM_SUBFORMAT_STD ((__force snd_pcm_subformat_t) 0) #define SNDRV_PCM_SUBFORMAT_LAST SNDRV_PCM_SUBFORMAT_STD +#ifdef CONFIG_ALPHA_DP264 +#define SNDRV_PCM_INFO_MMAP 0 /* the useful comment goes here */ +#define SNDRV_PCM_INFO_MMAP_VALID 0 +#else #define SNDRV_PCM_INFO_MMAP 0x00000001 /* hardware supports mmap */ #define SNDRV_PCM_INFO_MMAP_VALID 0x00000002 /* period data are valid during transfer */ +#endif + #define SNDRV_PCM_INFO_DOUBLE 0x00000004 /* Double buffering needed for PCM start/stop */ #define SNDRV_PCM_INFO_BATCH 0x00000010 /* double buffering */ #define SNDRV_PCM_INFO_INTERLEAVED 0x00000100 /* channels are interleaved */ | |