Messages in this thread | | | From | Rob Landley <> | Subject | Re: [PATCH] Corrections to Documentation/rbtree.txt | Date | Thu, 20 Mar 2008 13:39:18 -0500 |
| |
On Thursday 20 March 2008 10:29:57 Ian Abbott wrote: > From: Ian Abbott <abbotti@mev.co.uk> > > The description of the rb_entry() macro in Documentation/rbtree.txt seems > incorrect. This patch improves it (hopefully). Also I changed the example > code to call the previous 'my_search()' example instead of an undefined > 'mysearch()'.
I have no objection to the patch (and the my_search thing seems like an obvious typo), but is there a reason to prefer rb_entry() rather than container_of()? If so, the rationale might be a good thing to add to the documentation...
Rob -- "One of my most productive days was throwing away 1000 lines of code." - Ken Thompson.
| |