[lkml]   [2008]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 1/4] disk-protect: Add disk shock protection helpers to libata
> +	err_mask = ata_exec_internal(dev, &tf, NULL, DMA_NONE, NULL, 0, 0);
> + if (err_mask)
> + goto abort;

We assume you never use ata_exec_internal on a "live" to block layer
device, so this doesn't work for the general case. In the EH handler for
unparking it should be fine as the EH thread runs with the drive queue
shut down.

> +static inline int ata_id_has_unload(const u16 *id)
> +{
> + /* ATA-7 specifies two places to indicate unload feature support.
> + * Since I don't really understand the difference, I'll just check
> + * both and only return zero if none of them indicates otherwise. */

Probably wise and we can fix that once it is obvious what reality is


 \ /
  Last update: 2008-03-20 15:31    [W:0.136 / U:2.176 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site