Messages in this thread | | | Date | Mon, 03 Mar 2008 12:21:27 +0900 | From | KOSAKI Motohiro <> | Subject | Re: [PATCH 2.6.24] mm: BadRAM support for broken memory |
| |
Hi Rick
> > > +#define PG_badram 20 /* BadRam page */ > > > > some architecture use PG_reserved for treat bad memory. > > Why do you want introduce new page flag? > > It is clearer to properly name a flag, I suppose. > Is the use that you are mentioning the intended, and only use of the flag? > If not, I think it is clearer to use a separate flag instead of overloading > one.
hmmm unfortunately flag bit of struct page is very valuable resource rather than diamond on current implementaion ;-)
if you can change to no introduce new page flag, IMHO merge to mainline dramatically become easy.
> > for show_mem() improvement? > > For code clarity.
agreed with your code is clarify. but...
| |