[lkml]   [2008]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Subjectonly sparc can not include linux/pagemap.h?
    When trying to compile a m68k kernel with CONFIG_SWAP=n (e.g. allnoconfig), I'm
    bitten by:

    include/asm-generic/tlb.h: In function 'tlb_flush_mmu':
    include/asm-generic/tlb.h:76: error: implicit declaration of function 'release_pages'
    include/asm-generic/tlb.h: In function 'tlb_remove_page':
    include/asm-generic/tlb.h:105: error: implicit declaration of function 'page_cache_release'

    because include/linux/swap.h defines free_page_and_swap_cache() and
    free_pages_and_swap_cache() to page_cache_release() resp. release_pages()
    without including <linux/pagemap.h>.

    include/linux/swap.h has a comment that says:

    /* only sparc can not include linux/pagemap.h in this file
    * so leave page_cache_release and release_pages undeclared... */
    #define free_page_and_swap_cache(page) \
    #define free_pages_and_swap_cache(pages, nr) \
    release_pages((pages), (nr), 0);

    Is this comment still true?

    If not, I'd like to add

    #include <linux/pagemap.h>

    to the !CONFIG_SWAP section of include/linux/swap.h.

    If yes, would it be acceptible/work to add

    #ifndef CONFIG_SWAP
    #include <linux/pagemap.h>

    at the top of include/asm-generic/tlb.h?




    Geert Uytterhoeven -- There's lots of Linux beyond ia32 --

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds

     \ /
      Last update: 2008-03-16 13:25    [W:0.025 / U:215.316 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site