Messages in this thread | | | Date | Tue, 26 Feb 2008 10:32:24 -0800 | From | David Brownell <> | Subject | (regression) kernel/timeconst.h bugs with HZ=128 |
| |
I see these warnings on 32 bit ARM systems:
CC kernel/time.o kernel/time.c: In function 'msecs_to_jiffies': kernel/time.c:472: warning: integer constant is too large for 'long' type kernel/time.c: In function 'usecs_to_jiffies': kernel/time.c:487: warning: integer constant is too large for 'long' type
Line 472: return ((u64)MSEC_TO_HZ_MUL32 * m + MSEC_TO_HZ_ADJ32) line 487: return ((u64)USEC_TO_HZ_MUL32 * u + USEC_TO_HZ_ADJ32)
The problem seems to be that these constants from kernel/timeconst.h have too many digits:
#define ONLY_THIRTYTWO_BITS 0x01234567
#define MSEC_TO_HZ_ADJ32 0x3f7ced916 #define USEC_TO_HZ_ADJ32 0xfffbce4217d
Those *_ADJ32 constants should have "ULL" suffixes, yes? Adding that by hand resolves the problem, but only until the next time that header file gets regenerated.
Someone with observable Perl-fu should fix this ...
- Dave
| |