lkml.org 
[lkml]   [2008]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Change a WARN message in checkpatch
On Sun, Feb 24, 2008 at 4:18 PM, Benny Halevy <bhalevy@panasas.com> wrote:
[...]
> How about:
> - WARN("no space between function name and open parenthesis '('\n" . $herecurr);
> + WARN("there should be no space between function name and open parenthesis '('\n" . $herecurr);

I originally suggested:
+ WARN("don't put a space between
function name and open parenthesis '('\n" . $herecurr);
but I really prefer your version.

> The original phrasing can be interpreted like "there is no space between ..." and the correct
> interpretation should be "there should be no space between ..."

Indeed.

Ciao,
--
Paolo
http://paolo.ciarrocchi.googlepages.com/


\
 
 \ /
  Last update: 2008-02-24 23:27    [W:0.050 / U:0.620 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site