lkml.org 
[lkml]   [2008]   [Feb]   [24]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateSun, 24 Feb 2008 19:14:13 +0100
From"Paolo Ciarrocchi" <>
SubjectRe: [PATCH] Change a WARN message in checkpatch
On Sun, Feb 24, 2008 at 4:18 PM, Benny Halevy <bhalevy@panasas.com> wrote:
[...]
>  How about:
>  -                               WARN("no space between function name and open parenthesis '('\n" . $herecurr);
>  +                               WARN("there should be no space between function name and open parenthesis '('\n" . $herecurr);

I originally suggested:
+                               WARN("don't put a space between
function name and open parenthesis '('\n" . $herecurr);
but I really prefer your version.

>  The original phrasing can be interpreted like "there is no space between ..." and the correct
>  interpretation should be "there should be no space between ..."

Indeed.

Ciao,
-- 
Paolo
http://paolo.ciarrocchi.googlepages.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2008-02-24 23:27    [from the cache]
©2003-2008