Messages in this thread |  | | | Date | Sun, 24 Feb 2008 21:47:48 -0800 | | From | Benny Halevy <> | | Subject | Re: [PATCH] Change a WARN message in checkpatch |
On Feb. 24, 2008, 19:29 -0800, Andy Whitcroft <apw@shadowen.org> wrote:
> On Sun, Feb 24, 2008 at 07:14:13PM +0100, Paolo Ciarrocchi wrote:
>> On Sun, Feb 24, 2008 at 4:18 PM, Benny Halevy <bhalevy@panasas.com> wrote:
>> [...]
>>> How about:
>>> - WARN("no space between function name and open parenthesis '('\n" . $herecurr);
>>> + WARN("there should be no space between function name and open parenthesis '('\n" . $herecurr);
>> I originally suggested:
>> + WARN("don't put a space between
>> function name and open parenthesis '('\n" . $herecurr);
>> but I really prefer your version.
>>
>>> The original phrasing can be interpreted like "there is no space between ..." and the correct
>>> interpretation should be "there should be no space between ..."
>> Indeed.
>
> As we want the messages to be as short as possible, I am leaning towards
> standardising on:
>
> spaces prohibited <where>
> spaces required <where>
Sounds good to me.
Benny
>
> -apw
|  |