lkml.org 
[lkml]   [2008]   [Feb]   [25]   [last100]   RSS Feed
Views: [more markup]   [less markup]   [headers]   [forward]  
 
Messages in this thread
/
DateSun, 24 Feb 2008 21:47:48 -0800
FromBenny Halevy <>
SubjectRe: [PATCH] Change a WARN message in checkpatch
On Feb. 24, 2008, 19:29 -0800, Andy Whitcroft <apw@shadowen.org> wrote:
> On Sun, Feb 24, 2008 at 07:14:13PM +0100, Paolo Ciarrocchi wrote:
>> On Sun, Feb 24, 2008 at 4:18 PM, Benny Halevy <bhalevy@panasas.com> wrote:
>> [...]
>>>  How about:
>>>  -                               WARN("no space between function name and open parenthesis '('\n" . $herecurr);
>>>  +                               WARN("there should be no space between function name and open parenthesis '('\n" . $herecurr);
>> I originally suggested:
>> +                               WARN("don't put a space between
>> function name and open parenthesis '('\n" . $herecurr);
>> but I really prefer your version.
>>
>>>  The original phrasing can be interpreted like "there is no space between ..." and the correct
>>>  interpretation should be "there should be no space between ..."
>> Indeed.
> 
> As we want the messages to be as short as possible, I am leaning towards
> standardising on:
> 
> 	spaces prohibited <where>
> 	spaces required <where>

Sounds good to me.

Benny

> 
> -apw



\
 
 \ /
  Last update: 2008-02-25 05:51    [W:0.526 / U:0.090 seconds]
©2003-2008 Jasper Spaans