lkml.org 
[lkml]   [2008]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Subject[PATCH] char: static functions and integer as NULL pointer fixes in epca.c
From
Date
drivers/char/epca.c:926:28: warning: Using plain integer as NULL pointer
drivers/char/epca.c:1841:2: warning: Using plain integer as NULL pointer

Forward declarations were already marked static, mark the definitions too.
drivers/char/epca.c:2493:6: warning: symbol 'digi_send_break' was not declared. Should it be static?
drivers/char/epca.c:2881:12: warning: symbol 'init_PCI' was not declared. Should it be static?

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
drivers/char/epca.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/char/epca.c b/drivers/char/epca.c
index ffd747c..b034b37 100644
--- a/drivers/char/epca.c
+++ b/drivers/char/epca.c
@@ -923,7 +923,7 @@ static int pc_open(struct tty_struct *tty, struct file * filp)
return(-ENODEV);
}

- if ((bc = ch->brdchan) == 0) {
+ if ((bc = ch->brdchan) == NULL) {
tty->driver_data = NULL;
return -ENODEV;
}
@@ -1838,7 +1838,7 @@ static void epcaparam(struct tty_struct *tty, struct channel *ch)
unsigned mval, hflow, cflag, iflag;

bc = ch->brdchan;
- epcaassert(bc !=0, "bc out of range");
+ epcaassert(bc != NULL, "bc out of range");

assertgwinon(ch);
ts = tty->termios;
@@ -2490,7 +2490,7 @@ static void pc_unthrottle(struct tty_struct *tty)
}
}

-void digi_send_break(struct channel *ch, int msec)
+static void digi_send_break(struct channel *ch, int msec)
{
unsigned long flags;

@@ -2878,7 +2878,7 @@ static struct pci_device_id epca_pci_tbl[] = {

MODULE_DEVICE_TABLE(pci, epca_pci_tbl);

-int __init init_PCI (void)
+static int __init init_PCI (void)
{
memset (&epca_driver, 0, sizeof (epca_driver));
epca_driver.name = "epca";
--
1.5.4.2.200.g99e75




\
 
 \ /
  Last update: 2008-02-22 19:23    [W:0.048 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site