lkml.org 
[lkml]   [2008]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] virtio: make PCI devices take a virtio_pci module ref
    Date
    On Thursday 04 December 2008 23:14:31 Mark McLoughlin wrote:
    > Nothing takes a ref on virtio_pci, so even if you have
    > devices in use, rmmod will attempt to unload the module.
    >
    > Fix by simply making each device take a ref on the module.

    Hi Mark,

    Taking a reference to oneself is almost always wrong. I'm a little
    surprised that a successful call to pci_device->probe doesn't bump the
    module count though.

    Jesse?

    Thanks,
    Rusty.


    \
     
     \ /
      Last update: 2008-12-05 09:29    [W:0.019 / U:2.764 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site