lkml.org 
[lkml]   [2008]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Clean up namespace in kmap_types.h
On Wed, Dec 03, 2008 at 11:40:01AM +0100, Arnd Bergmann wrote:
> On Wednesday 03 December 2008, Andi Kleen wrote:
> > Clean up namespace in kmap_types.h
> >
> > During debugging I often use custom "D" macros. But I ran
> > into a name space conflict with kmap_types.h which also defines a D macro.
> > Rename the kmap_types.h one to KMAPD.
> >
> > No semantical changes.
> >
> > Signed-off-by: Andi Kleen <ak@linux.intel.com>
>
> The patch looks ok, but it seems wrong to do this only on one architecture,
> because kmap_types.h is mostly identical across all architectures.
>
> I'm working on patches to consolidate a lot of generic headers, why not
> add this in a generic way and make x86 use that version?

I was hoping that it could be still fixed for 2.6.28. Perhaps
that would be too intrusive that late? That is why I hope
it can be still considered even if it's x86 only.

For .29 I suspect in fact the best way would be to just move it into linux
and use a superset because I don't think it's a big problem to waste 3-4
pages of virtual space for this.

> --- /dev/null
> +++ b/include/asm-generic/kmap_types.h
> @@ -0,0 +1,29 @@
> +#ifndef __ASM_GENERIC_KMAP_TYPES_H
> +#define __ASM_GENERIC_KMAP_TYPES_H

So are you submitting this?

-Andi


\
 
 \ /
  Last update: 2008-12-03 12:13    [W:0.093 / U:0.560 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site