Messages in this thread | | | Date | Wed, 3 Dec 2008 13:01:10 +0100 | From | Sam Ravnborg <> | Subject | New location for generic headers? |
| |
On Wed, Dec 03, 2008 at 11:40:01AM +0100, Arnd Bergmann wrote: > On Wednesday 03 December 2008, Andi Kleen wrote: > > Clean up namespace in kmap_types.h > > > > During debugging I often use custom "D" macros. But I ran > > into a name space conflict with kmap_types.h which also defines a D macro. > > Rename the kmap_types.h one to KMAPD. > > > > No semantical changes. > > > > Signed-off-by: Andi Kleen <ak@linux.intel.com> > > The patch looks ok, but it seems wrong to do this only on one architecture, > because kmap_types.h is mostly identical across all architectures. > > I'm working on patches to consolidate a lot of generic headers, why not > add this in a generic way and make x86 use that version?
Should we try to get rid of all those silly: #include <asm-generic/foo.h> files we have in arch/$ARCH/include/asm?
We could for example add include/generic/ last in the search path. Or we could add the files in include/asm and add that last in the search path.
Then if we do not find <asm/foo.h> in arch/$ARCH/include/asm/ then we search include/asm.
Before we can do this we need to get rid of the last users of include/asm-$ARCH - but we are almost there. Only m68k seems to require some effort.
Sam
| |