lkml.org 
[lkml]   [2008]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [patch 5/8] SDHCI: Samsung SDHCI (HSMMC) driver
On Tue, 02 Dec 2008 15:40:23 +0000
Ben Dooks <ben-linux@fluff.org> wrote:

> Index: linux.git/drivers/mmc/host/Kconfig
> ===================================================================
> --- linux.git.orig/drivers/mmc/host/Kconfig 2008-12-01 23:18:20.000000000 +0000
> +++ linux.git/drivers/mmc/host/Kconfig 2008-12-01 23:25:18.000000000 +0000
> @@ -48,6 +48,18 @@ config MMC_SDHCI_PCI
>
> If unsure, say N.
>
> +config MMC_SDHCI_S3C
> + tristate "SDHCI support on Samsung S3C SoC"
> + depends on MMC_SDHCI && (PLAT_S3C24XX || PLAT_S3C64XX)
> + help
> + This selects the Secure Digital Host Controller Interface (SDHCI)
> + often referrered to as the HSMMC block in some of the Samsung S3C
> + range of SoC.
> +
> + If you have a controller with this interface, say Y or M here.
> +
> + If unsure, say N.
> +
> config MMC_RICOH_MMC
> tristate "Ricoh MMC Controller Disabler (EXPERIMENTAL)"
> depends on MMC_SDHCI_PCI

You should probably put it under MMC_RICOH_MMC as that will become a
subentry under MMC_SDHCI_PCI.

> +static void sdhci_s3c_set_ios(struct sdhci_host *host,
> + struct mmc_ios *ios)
> +{
> + struct sdhci_s3c *ourhost = to_s3c(host);
> + struct s3c_sdhci_platdata *pdata = ourhost->pdata;
> +
> + if (pdata->cfg_card)
> + pdata->cfg_card(ourhost->pdev, host->ioaddr, ios);
> +}

I'm still waiting for a proper reason to allow this hook. Since you've
added this, I assume you have at least one implementation of cfg_card.
Care to include that so that I can see what it is you're trying to do?

--
-- Pierre Ossman
WARNING: This correspondence is being monitored by the
Swedish government. Make sure your server uses encryption
for SMTP traffic and consider using PGP for end-to-end
encryption.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2008-12-21 14:35    [W:0.094 / U:1.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site