Messages in this thread | | | Date | Sun, 2 Nov 2008 07:59:47 +0600 | From | "Rakib Mullick" <> | Subject | Re: [PATCH] kernel/cpu.c: Section mismatch warning fix. |
| |
On 10/31/08, Ingo Molnar <mingo@elte.hu> wrote: > > * Rakib Mullick <rakib.mullick@gmail.com> wrote: > > > you've tested that on x86, right? Have you checked/reviewed all the > non-x86 architecture codepaths: > > ./arch/m32r/kernel/smpboot.c: notify_cpu_starting(cpu_id); > ./arch/cris/arch-v32/kernel/smp.c: notify_cpu_starting(cpu); > ./arch/s390/kernel/smp.c: notify_cpu_starting(smp_processor_id()); > ./arch/x86/mach-voyager/voyager_smp.c: notify_cpu_starting(cpuid); > ./arch/x86/kernel/smpboot.c: notify_cpu_starting(cpuid); > ./arch/mips/kernel/smp.c: notify_cpu_starting(cpu); > ./arch/sparc64/kernel/smp.c: notify_cpu_starting(cpuid); > ./arch/ia64/kernel/smpboot.c: notify_cpu_starting(cpuid); > ./arch/um/kernel/smp.c: notify_cpu_starting(cpu); > ./arch/sparc/kernel/sun4d_smp.c: notify_cpu_starting(cpuid); > ./arch/sparc/kernel/sun4m_smp.c: notify_cpu_starting(cpuid); > ./arch/powerpc/kernel/smp.c: notify_cpu_starting(cpu); > ./arch/alpha/kernel/smp.c: notify_cpu_starting(cpuid); > ./arch/sh/kernel/smp.c: notify_cpu_starting(smp_processor_id()); > ./arch/arm/kernel/smp.c: notify_cpu_starting(cpu); > > to make sure that they never use this function after free_initmem()? Above codepaths are basically called during initialization, where all the CPU's are initiated. When we complete the initial bootup then free_initmem is called. So, If i'm not wrong they're not using this function after free_initmem().And notify_cpu_started(cpuid) is declared when CPU_HOTPLUG is not set. So, It's safe also from CPU hotpluging POV. Am I missing anything?
Rakib > > Ingo >
| |