lkml.org 
[lkml]   [2008]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kernel/cpu.c: Section mismatch warning fix.
On Thu, 30 Oct 2008 10:04:54 +0600
"Rakib Mullick" <rakib.mullick@gmail.com> wrote:

> LD kernel/built-in.o
> WARNING: kernel/built-in.o(.text+0xb7c8): Section mismatch in
> reference from the function notify_cpu_starting() to the variable
> .cpuinit.data:cpu_chain
> The function notify_cpu_starting() references
> the variable __cpuinitdata cpu_chain.
> This is often because notify_cpu_starting lacks a __cpuinitdata
> annotation or the annotation of cpu_chain is wrong.
>
> This patch fixes the above section mismatch warning. If anything else
> please notice.
> Thanks.
>
> Signed-off-by: Md.Rakib H. Mullick <rakib.mullick@gmail.com>
>
> --- linux-2.6-orig/kernel/cpu.c 2008-10-28 20:52:38.000000000 +0600
> +++ linux-2.6/kernel/cpu.c 2008-10-28 22:46:22.000000000 +0600
> @@ -462,7 +462,7 @@ out:
> * It must be called by the arch code on the new cpu, before the new cpu
> * enables interrupts and before the "boot" cpu returns from __cpu_up().
> */
> -void notify_cpu_starting(unsigned int cpu)
> +void __cpuinit notify_cpu_starting(unsigned int cpu)
> {
> unsigned long val = CPU_STARTING;

arch/alpha/kernel/smp.c calls notify_cpu_starting() from __init code.

arch/cris/arch-v32/kernel/smp.c calls notify_cpu_starting() from __init code.

arch/x86/mach-voyager/voyager_smp.c calls notify_cpu_starting() from
__init code.

arch/m32r/kernel/smpboot.c calls notify_cpu_starting() from __init code.

arch/sparc/kernel/sun4d_smp.c calls notify_cpu_starting() from __init code.

arch/powerpc/kernel/smp.c calls notify_cpu_starting() from __devinit
code.

arch/um/kernel/smp.c calls notify_cpu_starting() from .text code.


The other nine callers call notify_cpu_starting() from __cpuinit code.


What a mess.


\
 
 \ /
  Last update: 2008-11-04 00:37    [W:0.099 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site