Messages in this thread | | | Date | Wed, 01 Oct 2008 10:56:32 +0200 | From | Takashi Iwai <> | Subject | Re: [PATCH -tip] pcm_native: label out defined but not used |
| |
At Wed, 1 Oct 2008 10:32:24 +0200, Ingo Molnar wrote: > > > * Takashi Iwai <tiwai@suse.de> wrote: > > > At Wed, 1 Oct 2008 09:59:21 +0200, > > Ingo Molnar wrote: > > > > > > > > > (Cc:-ed Taskashi for this ALSA cleanup patch.) > > > > This label is used when the debug option is enabled. > > ah, indeed: > > snd_assert(substream != NULL, goto out); > > if then i'd suggest to clean it up like this: > > if (snd_assert(substream != NULL)) > goto out; > > this is how DEBUG_LOCKS_WARN_ON() is used in kernel/lockdep.c for > example. Putting code flow side-effects into debug macros looks a bit > weird.
Yeah, already a similar change was done in the latest ALSA tree :)
thanks,
Takashi
| |