lkml.org 
[lkml]   [2008]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -tip] pcm_native: label out defined but not used
At Wed, 1 Oct 2008 10:32:24 +0200,
Ingo Molnar wrote:
>
>
> * Takashi Iwai <tiwai@suse.de> wrote:
>
> > At Wed, 1 Oct 2008 09:59:21 +0200,
> > Ingo Molnar wrote:
> > >
> > >
> > > (Cc:-ed Taskashi for this ALSA cleanup patch.)
> >
> > This label is used when the debug option is enabled.
>
> ah, indeed:
>
> snd_assert(substream != NULL, goto out);
>
> if then i'd suggest to clean it up like this:
>
> if (snd_assert(substream != NULL))
> goto out;
>
> this is how DEBUG_LOCKS_WARN_ON() is used in kernel/lockdep.c for
> example. Putting code flow side-effects into debug macros looks a bit
> weird.

Yeah, already a similar change was done in the latest ALSA tree :)


thanks,

Takashi


\
 
 \ /
  Last update: 2008-10-01 10:59    [W:0.191 / U:0.268 seconds]
©2003-2014 Jasper Spaans. Advertise on this site