lkml.org 
[lkml]   [2008]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -tip] pcm_native: label out defined but not used

* Takashi Iwai <tiwai@suse.de> wrote:

> At Wed, 1 Oct 2008 09:59:21 +0200,
> Ingo Molnar wrote:
> >
> >
> > (Cc:-ed Taskashi for this ALSA cleanup patch.)
>
> This label is used when the debug option is enabled.

ah, indeed:

snd_assert(substream != NULL, goto out);

if then i'd suggest to clean it up like this:

if (snd_assert(substream != NULL))
goto out;

this is how DEBUG_LOCKS_WARN_ON() is used in kernel/lockdep.c for
example. Putting code flow side-effects into debug macros looks a bit
weird.

Ingo


\
 
 \ /
  Last update: 2008-10-01 10:35    [W:0.056 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site