lkml.org 
[lkml]   [2008]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] driver: ip27-rtc - convert ioctl to unlocked_ioctl
    Date
    On Sunday 13 January 2008 21:32:23 Cyrill Gorcunov wrote:
    > This patch converts ioctl call to unlocked_ioctl form with
    > explicit big-kernel-lock.

    > Also it makes a bit of cleanup
    > converting miscdevice structure initialization to C99 form.

    First please always send cleanup patches separately. I think you have more
    than just the C99 conversion.

    Were you even able to compile it? Since ip27 is ia64 only that would need
    an IA64 cross compiler or a native ia64 machine.

    It's probably better to focus on drivers only that actually build
    on x86 :- see http://www.halobates.de/allyes for a compile log
    showing all buildable files for x86-64 and i386.

    Other than that the patch looks ok to me, but I haven't tried to
    compile it either.

    -Andi


    \
     
     \ /
      Last update: 2008-01-14 00:11    [W:0.036 / U:150.124 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site