lkml.org 
[lkml]   [2008]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] driver: ip27-rtc - convert ioctl to unlocked_ioctl
    Thanks, Alexey for review, i'll make it updated tomorrow. (sorry for top-post)

    On 1/14/08, Alexey Dobriyan <adobriyan@gmail.com> wrote:
    > On Sun, Jan 13, 2008 at 11:32:23PM +0300, Cyrill Gorcunov wrote:
    > > This patch converts ioctl call to unlocked_ioctl form with
    > > explicit big-kernel-lock. Also it makes a bit of cleanup
    > > converting miscdevice structure initialization to C99 form.
    > >
    > > Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
    > > ---
    > >
    > > Any comments are welcome.
    > > This is untested code - i've no such chip on my laptop.
    > >
    > > Andi, i think we could use mutex to eliminate BKL, but not sure.
    >
    > Looks like it can be dropped here. All usage of rtc-> is done under
    > rtc_lock. Every other variable there is thread-local.
    >


    \
     
     \ /
      Last update: 2008-01-13 22:27    [W:0.024 / U:1.016 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site