lkml.org 
[lkml]   [2007]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subjectsysfs: spit a warning to users when they try to create a duplicate sysfs file
    We want to let people know when we create a duplicate sysfs file, as
    they need to fix up their code.


    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    fs/sysfs/dir.c | 6 +++++-
    1 file changed, 5 insertions(+), 1 deletion(-)

    --- a/fs/sysfs/dir.c
    +++ b/fs/sysfs/dir.c
    @@ -428,8 +428,12 @@ void sysfs_addrm_start(struct sysfs_addr
    */
    int sysfs_add_one(struct sysfs_addrm_cxt *acxt, struct sysfs_dirent *sd)
    {
    - if (sysfs_find_dirent(acxt->parent_sd, sd->s_name))
    + if (sysfs_find_dirent(acxt->parent_sd, sd->s_name)) {
    + printk(KERN_WARNING, "sysfs: duplicate filename '%s' "
    + "can not be created\n", sd->s_name);
    + WARN_ON(1);
    return -EEXIST;
    + }

    sd->s_parent = sysfs_get(acxt->parent_sd);

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2007-09-14 01:51    [W:0.023 / U:67.528 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site