Messages in this thread Patch in this message | | | Date | Mon, 27 Aug 2007 23:28:53 +0200 | From | Adrian Bunk <> | Subject | [2.6 patch] n_hdlc.c: fix check-after-use |
| |
The Coverity checker spotted that we'd have already oops'ed if "tty" was NULL.
Since "tty" can't be NULL when we reach this line of code this patch removes the NULL check.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
This patch has been sent on: - 14 Aug 2007
--- linux-2.6.23-rc1-mm2/drivers/char/n_hdlc.c.old 2007-08-08 06:11:02.000000000 +0200 +++ linux-2.6.23-rc1-mm2/drivers/char/n_hdlc.c 2007-08-08 06:11:15.000000000 +0200 @@ -220,25 +220,25 @@ static void n_hdlc_release(struct n_hdlc *n_hdlc) { struct tty_struct *tty = n_hdlc2tty (n_hdlc); struct n_hdlc_buf *buf; if (debuglevel >= DEBUG_LEVEL_INFO) printk("%s(%d)n_hdlc_release() called\n",__FILE__,__LINE__); /* Ensure that the n_hdlcd process is not hanging on select()/poll() */ wake_up_interruptible (&tty->read_wait); wake_up_interruptible (&tty->write_wait); - if (tty != NULL && tty->disc_data == n_hdlc) + if (tty->disc_data == n_hdlc) tty->disc_data = NULL; /* Break the tty->n_hdlc link */ /* Release transmit and receive buffers */ for(;;) { buf = n_hdlc_buf_get(&n_hdlc->rx_free_buf_list); if (buf) { kfree(buf); } else break; } for(;;) { buf = n_hdlc_buf_get(&n_hdlc->tx_free_buf_list); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |