lkml.org 
[lkml]   [2007]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 01/23] nfs: remove congestion_end()
    Its redundant, clear_bdi_congested() already wakes the waiters.

    Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
    ---
    fs/nfs/write.c | 5 ++---
    include/linux/backing-dev.h | 1 -
    mm/backing-dev.c | 13 -------------
    3 files changed, 2 insertions(+), 17 deletions(-)

    Index: linux-2.6/fs/nfs/write.c
    ===================================================================
    --- linux-2.6.orig/fs/nfs/write.c
    +++ linux-2.6/fs/nfs/write.c
    @@ -235,10 +235,8 @@ static void nfs_end_page_writeback(struc
    struct nfs_server *nfss = NFS_SERVER(inode);

    end_page_writeback(page);
    - if (atomic_long_dec_return(&nfss->writeback) < NFS_CONGESTION_OFF_THRESH) {
    + if (atomic_long_dec_return(&nfss->writeback) < NFS_CONGESTION_OFF_THRESH)
    clear_bdi_congested(&nfss->backing_dev_info, WRITE);
    - congestion_end(WRITE);
    - }
    }

    /*
    Index: linux-2.6/include/linux/backing-dev.h
    ===================================================================
    --- linux-2.6.orig/include/linux/backing-dev.h
    +++ linux-2.6/include/linux/backing-dev.h
    @@ -93,7 +93,6 @@ static inline int bdi_rw_congested(struc
    void clear_bdi_congested(struct backing_dev_info *bdi, int rw);
    void set_bdi_congested(struct backing_dev_info *bdi, int rw);
    long congestion_wait(int rw, long timeout);
    -void congestion_end(int rw);

    #define bdi_cap_writeback_dirty(bdi) \
    (!((bdi)->capabilities & BDI_CAP_NO_WRITEBACK))
    Index: linux-2.6/mm/backing-dev.c
    ===================================================================
    --- linux-2.6.orig/mm/backing-dev.c
    +++ linux-2.6/mm/backing-dev.c
    @@ -54,16 +54,3 @@ long congestion_wait(int rw, long timeou
    return ret;
    }
    EXPORT_SYMBOL(congestion_wait);
    -
    -/**
    - * congestion_end - wake up sleepers on a congested backing_dev_info
    - * @rw: READ or WRITE
    - */
    -void congestion_end(int rw)
    -{
    - wait_queue_head_t *wqh = &congestion_wqh[rw];
    -
    - if (waitqueue_active(wqh))
    - wake_up(wqh);
    -}
    -EXPORT_SYMBOL(congestion_end);
    --

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-08-16 10:41    [W:0.047 / U:30.760 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site