Messages in this thread | | | Date | Fri, 17 Aug 2007 11:48:04 -0400 | From | Josef Sipek <> | Subject | Re: [PATCH 02/23] lib: percpu_counter_add |
| |
On Thu, Aug 16, 2007 at 09:45:27AM +0200, Peter Zijlstra wrote: ... > Index: linux-2.6/fs/ext2/balloc.c > =================================================================== > --- linux-2.6.orig/fs/ext2/balloc.c > +++ linux-2.6/fs/ext2/balloc.c > @@ -163,7 +163,7 @@ static int reserve_blocks(struct super_b > return 0; > } > > - percpu_counter_mod(&sbi->s_freeblocks_counter, -count); > + percpu_counter_add(&sbi->s_freeblocks_counter, -count);
Out of curiosity, I noticed similar thing being done in the vm code, what is preferred:
foobar_add(&counter, -num);
or
foobar_sub(&counter, num);
?
Josef 'Jeff' Sipek.
-- Research, n.: Consider Columbus: He didn't know where he was going. When he got there he didn't know where he was. When he got back he didn't know where he had been. And he did it all on someone else's money. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |