Messages in this thread | | | Date | Thu, 5 Jul 2007 00:48:59 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH] Optional Beeping During Resume From Suspend To Ram. |
| |
Hi!
> Documentation is also an issue. Your patch should update the kernel_parameters > file so users can know how to get the beeping to happen. It would be nice if > it mentioned the proc entry too.
Fixed the docs.
> > @@ -80,9 +82,11 @@ static int __init acpi_sleep_setup(char > > > > __setup("acpi_sleep=", acpi_sleep_setup); > > > > +/* Ouch, we want to delete this. We already have better version in > userspace, in > > + s2ram from suspend.sf.net project */ > > Do we? This version has advantages in not requiring any userspace app and in > being able to work even if you can't yet get as far as having
Take a look at the file. It has whitelist with just one entry, too bad.
> > @@ -124,7 +124,7 @@ real_save_cr3: .long 0 > > real_save_cr4: .long 0 > > real_magic: .long 0 > > video_mode: .long 0 > > -video_flags: .long 0 > > +realmode_flags: .long 0 > > beep_flags: .long 0 > > real_efer_save_restore: .long 0 > > real_save_efer_edx: .long 0 > > Beep_flags should be removed too if you're sticking with /proc.
Fixed. Pavel
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |