lkml.org 
[lkml]   [2007]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Optional Beeping During Resume From Suspend To Ram.
    Hi!

    > > > > @@ -80,9 +82,11 @@ static int __init acpi_sleep_setup(char
    > > > >
    > > > > __setup("acpi_sleep=", acpi_sleep_setup);
    > > > >
    > > > > +/* Ouch, we want to delete this. We already have better version in
    > > > userspace, in
    > > > > + s2ram from suspend.sf.net project */
    > > >
    > > > Do we? This version has advantages in not requiring any userspace app and
    > in
    > > > being able to work even if you can't yet get as far as having
    > >
    > > Take a look at the file. It has whitelist with just one entry, too
    > > bad.
    >
    > The contents of the whitelist are irrelevant. My laptop needs this
    > functionality, but I haven't bothered to send you a whitelist entry, in part
    > because I don't use s2ram.
    >
    > Regardless of that, if you had read the whole comment (you've deleted half of
    > it), you would have noticed that I ended up changing my mind and instead
    > saying "Why not just delete the __setup now, or at least put it in the
    > deprecated file?"

    That should be certainly done in separate patch, right? It is on my
    todolist somewhere now.

    > > > > @@ -124,7 +124,7 @@ real_save_cr3: .long 0
    > > > > real_save_cr4: .long 0
    > > > > real_magic: .long 0
    > > > > video_mode: .long 0
    > > > > -video_flags: .long 0
    > > > > +realmode_flags: .long 0
    > > > > beep_flags: .long 0
    > > > > real_efer_save_restore: .long 0
    > > > > real_save_efer_edx: .long 0
    > > >
    > > > Beep_flags should be removed too if you're sticking with /proc.
    > >
    > > Fixed.
    >
    > Ta. But you didn't answer the question - why /proc and not sysfs?

    Do you seriously advocate setting two bits of one variable from /proc,
    and one more bit from /sys?
    Pavel

    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-07-05 01:05    [W:0.022 / U:0.116 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site