lkml.org 
[lkml]   [2007]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix leaks on /proc/{*/sched,sched_debug,timer_list,timer_stats}

* Alexey Dobriyan <adobriyan@sw.ru> wrote:

> On every open/close one struct seq_operations leaks.
> Kudos to /proc/slab_allocators.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>

ouch ...

Acked-by: Ingo Molnar <mingo@elte.hu>

-stable material too, as far as timer_info/stats goes.

> - .release = seq_release,
> + .release = single_release,

i think seq_release() definitely needs to grow a WARN_ON() if it's being
used on an inode that was opened via single_open(). This bug is so
easily committed, and nothing but a small leak reminds us on it.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-07-17 14:39    [W:0.408 / U:0.016 seconds]
©2003-2011 Jasper Spaans. Advertise on this site