lkml.org 
[lkml]   [2007]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] Fix leaks on /proc/{*/sched,sched_debug,timer_list,timer_stats}
    On every open/close one struct seq_operations leaks.
    Kudos to /proc/slab_allocators.

    Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
    ---

    fs/proc/base.c | 2 +-
    kernel/sched_debug.c | 2 +-
    kernel/time/timer_list.c | 2 +-
    kernel/time/timer_stats.c | 2 +-
    4 files changed, 4 insertions(+), 4 deletions(-)

    --- a/fs/proc/base.c
    +++ b/fs/proc/base.c
    @@ -926,7 +926,7 @@ static const struct file_operations proc_pid_sched_operations = {
    .read = seq_read,
    .write = sched_write,
    .llseek = seq_lseek,
    - .release = seq_release,
    + .release = single_release,
    };

    #endif
    --- a/kernel/sched_debug.c
    +++ b/kernel/sched_debug.c
    @@ -200,7 +200,7 @@ static struct file_operations sched_debug_fops = {
    .open = sched_debug_open,
    .read = seq_read,
    .llseek = seq_lseek,
    - .release = seq_release,
    + .release = single_release,
    };

    static int __init init_sched_debug_procfs(void)
    --- a/kernel/time/timer_list.c
    +++ b/kernel/time/timer_list.c
    @@ -267,7 +267,7 @@ static struct file_operations timer_list_fops = {
    .open = timer_list_open,
    .read = seq_read,
    .llseek = seq_lseek,
    - .release = seq_release,
    + .release = single_release,
    };

    static int __init init_timer_list_procfs(void)
    --- a/kernel/time/timer_stats.c
    +++ b/kernel/time/timer_stats.c
    @@ -399,7 +399,7 @@ static struct file_operations tstats_fops = {
    .read = seq_read,
    .write = tstats_write,
    .llseek = seq_lseek,
    - .release = seq_release,
    + .release = single_release,
    };

    void __init init_timer_stats(void)
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-07-17 14:29    [W:0.022 / U:62.148 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site