Messages in this thread | | | Subject | Re: [PATCH] the wrong variable checked after request_irq() | From | Benjamin Herrenschmidt <> | Date | Mon, 16 Jul 2007 07:40:38 +1000 |
| |
On Sun, 2007-07-15 at 20:59 +0100, Al Viro wrote: > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Out of curiosity, how did you pick it up ? You have some automated tool to catch that (or sparse changes) or you just did -lots- of code inspection ?
Cheers, Ben.
> --- > arch/powerpc/platforms/pseries/setup.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/powerpc/platforms/pseries/setup.c b/arch/powerpc/platforms/pseries/setup.c > index 470db6e..a031d99 100644 > --- a/arch/powerpc/platforms/pseries/setup.c > +++ b/arch/powerpc/platforms/pseries/setup.c > @@ -176,7 +176,7 @@ static void __init pseries_mpic_init_IRQ(void) > return; > > cascade_irq = irq_of_parse_and_map(cascade, 0); > - if (cascade == NO_IRQ) { > + if (cascade_irq == NO_IRQ) { > printk(KERN_ERR "mpic: failed to map cascade interrupt"); > return; > }
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |