Messages in this thread | | | Date | Fri, 13 Jul 2007 19:39:49 +0200 | From | Jens Axboe <> | Subject | Re: On current git head webservers stopped working |
| |
On Fri, Jul 13 2007, Linus Torvalds wrote: > > > On Fri, 13 Jul 2007, Jens Axboe wrote: > > > > Does this work? > > Ok, so it apparently works, but: > > > diff --git a/fs/splice.c b/fs/splice.c > > index ed2ce99..92646aa 100644 > > --- a/fs/splice.c > > +++ b/fs/splice.c > > @@ -491,7 +491,7 @@ ssize_t generic_file_splice_read(struct file *in, loff_t *ppos, > > > > ret = 0; > > spliced = 0; > > - while (len) { > > + while (len && !spliced) { > > ret = __generic_file_splice_read(in, ppos, pipe, len, flags); > > This hunk basically make sthe whole "while" loop pointless. You'll never > go through it more than once. > > So at that point, maybe the loop should be removed entirely? Or maybe this > part of the patch is wrong, and the fix was in the _other_ parts?
It'll likely work without that hunk, and you are right - the loop should just go now. I'll update that piece in a sub sequent patch!
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |