lkml.org 
[lkml]   [2007]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: On current git head webservers stopped working


On Fri, 13 Jul 2007, Jens Axboe wrote:
>
> Does this work?

Ok, so it apparently works, but:

> diff --git a/fs/splice.c b/fs/splice.c
> index ed2ce99..92646aa 100644
> --- a/fs/splice.c
> +++ b/fs/splice.c
> @@ -491,7 +491,7 @@ ssize_t generic_file_splice_read(struct file *in, loff_t *ppos,
>
> ret = 0;
> spliced = 0;
> - while (len) {
> + while (len && !spliced) {
> ret = __generic_file_splice_read(in, ppos, pipe, len, flags);

This hunk basically make sthe whole "while" loop pointless. You'll never
go through it more than once.

So at that point, maybe the loop should be removed entirely? Or maybe this
part of the patch is wrong, and the fix was in the _other_ parts?

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-07-13 19:31    [W:0.058 / U:1.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site