lkml.org 
[lkml]   [2007]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 5/5] crypto: Add LZO compression support to the crypto interface
    On 5/1/07, Richard Purdie <rpurdie@openedhand.com> wrote:
    > +static int lzo_init(struct crypto_tfm *tfm)
    > +{
    > + struct lzo_ctx *ctx = crypto_tfm_ctx(tfm);
    > +
    > + ctx->lzo_mem = vmalloc(LZO1X_MEM_COMPRESS);
    > +
    > + if (!ctx->lzo_mem) {
    > + vfree(ctx->lzo_mem);

    Heh. What's (why's) this? You _can_ {k, v}free NULL but doing so after
    explicitly checking for it is ... ... insane!

    > + return -ENOMEM;

    Yeah. Just return -ENOMEM; and be done with it.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-05-04 10:13    [W:0.020 / U:29.912 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site