Messages in this thread | | | Date | Fri, 4 May 2007 13:39:20 +0530 | From | "Satyam Sharma" <> | Subject | Re: [PATCH 5/5] crypto: Add LZO compression support to the crypto interface |
| |
On 5/1/07, Richard Purdie <rpurdie@openedhand.com> wrote: > +static int lzo_init(struct crypto_tfm *tfm) > +{ > + struct lzo_ctx *ctx = crypto_tfm_ctx(tfm); > + > + ctx->lzo_mem = vmalloc(LZO1X_MEM_COMPRESS); > + > + if (!ctx->lzo_mem) { > + vfree(ctx->lzo_mem);
Heh. What's (why's) this? You _can_ {k, v}free NULL but doing so after explicitly checking for it is ... ... insane!
> + return -ENOMEM;
Yeah. Just return -ENOMEM; and be done with it. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |