Messages in this thread | | | Subject | Re: [PATCH 5/5] crypto: Add LZO compression support to the crypto interface | From | Richard Purdie <> | Date | Fri, 04 May 2007 09:39:23 +0100 |
| |
On Fri, 2007-05-04 at 13:39 +0530, Satyam Sharma wrote: > On 5/1/07, Richard Purdie <rpurdie@openedhand.com> wrote: > > +static int lzo_init(struct crypto_tfm *tfm) > > +{ > > + struct lzo_ctx *ctx = crypto_tfm_ctx(tfm); > > + > > + ctx->lzo_mem = vmalloc(LZO1X_MEM_COMPRESS); > > + > > + if (!ctx->lzo_mem) { > > + vfree(ctx->lzo_mem); > > Heh. What's (why's) this? You _can_ {k, v}free NULL but doing so after > explicitly checking for it is ... ... insane!
True, there used to be two buffers allocated there and I've missed a sensible cleanup when I removed one. I'll fix it, thanks.
Cheers,
Richard
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |