[lkml]   [2007]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [patch 9/9] Scheduler profiling - Use conditional calls
    * Matt Mackall ( wrote:
    > > - profile_hit(SCHED_PROFILING, __builtin_return_address(0));
    > > + cond_call(profile_on,
    > > + profile_hit(SCHED_PROFILING, __builtin_return_address(0)));
    > I think we could do better here pretty trivially. profile hit still
    > has an if (unlikely(prof_on == TYPE)). Shouldn't we just have a
    > cond_call type for "sched_profiling" and cond_call profile_hits(type,
    > ip, 1) directly?

    Yes, that's much better. I will leave the profile_hit as a simple call
    to profile hits with one parameter for now, although it might be a
    little bit useless. Being able to select independently which specific
    site must be enabled is interesting too, therefore I will use the more
    precise "sched_profiling" to replace "profile_on".

    I guess we could also rework profile.c:profile_tick() in the same way,
    using "cpu_profiling". It would be interesting to wrap the whole
    profile_tick() call in a cond_call, but it would involve dealing with
    more than one different things that are part of this function and can
    have to run. The same will apply to kvm and sleep profiling.


    Mathieu Desnoyers
    Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
    OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2007-05-31 23:39    [W:0.020 / U:27.480 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site